Skip to content

Commit 3e4df5d

Browse files
delphos-mikeclaude
andcommitted
Fix test assertions: change 'using notebook' to 'Successfully activate notebook'
Addresses feedback from @echarles and @ChengJiale150 on PR #138. The three failing tests were checking for incorrect string in output: - Expected: 'using notebook' - Actual: 'Successfully activate notebook' Fixed assertions in: - test_rtc_mode_for_cell_operations (line 48) - test_reading_tools_see_unsaved_changes (line 130) - test_jupyter_collaboration_extension_loaded (line 207) This matches the assertion pattern used in tests/test_tools.py. 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
1 parent 30a22fa commit 3e4df5d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tests/test_rtc_mode.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ async def test_rtc_mode_for_cell_operations(
4545
"test_rtc.ipynb",
4646
mode="create"
4747
)
48-
assert "using notebook" in create_result
48+
assert "Successfully activate notebook" in create_result
4949
logger.info("✓ Created test notebook")
5050

5151
# 2. Insert a cell (should use RTC mode, not file mode)
@@ -127,7 +127,7 @@ async def test_reading_tools_see_unsaved_changes(
127127
"test_read_live.ipynb",
128128
mode="create"
129129
)
130-
assert "using notebook" in create_result
130+
assert "Successfully activate notebook" in create_result
131131

132132
insert_result = await mcp_client_parametrized.insert_cell(
133133
0,
@@ -204,7 +204,7 @@ async def test_jupyter_collaboration_extension_loaded(
204204
"test_extension.ipynb",
205205
mode="create"
206206
)
207-
assert "using notebook" in create_result
207+
assert "Successfully activate notebook" in create_result
208208

209209
# If we got here, the extension infrastructure is working
210210
logger.info("✓ jupyter-collaboration extension is functional")

0 commit comments

Comments
 (0)