Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion/mongodb): MongoDB source unable to parse datetimes with years > 9999 #10110

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(ingestion/mongodb): MongoDB source unable to parse datetimes with years > 9999 #10110

merged 1 commit into from
Apr 4, 2024

Conversation

jonasHanhan
Copy link
Contributor

@jonasHanhan jonasHanhan commented Mar 22, 2024 •
edited by hsheth2
Loading

… years > 9999

Closes #10079

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 22, 2024
hsheth2
hsheth2 reviewed Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one quick suggestion, and also it seems like the linter isn't happy

looks good other than that

metadata-ingestion/src/datahub/ingestion/source/mongodb.py Outdated Show resolved Hide resolved
@jonasHanhan jonasHanhan force-pushed the fix-python-datetime-of-mongodb-is-larger branch from afa1221 to 4b7dec1 Compare March 28, 2024 07:15
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Mar 29, 2024
@hsheth2
Copy link
Collaborator

hsheth2 commented Apr 1, 2024

Looks like CI is failing

FAILED tests/integration/mongodb/test_mongodb.py::test_mongodb_ingest - datahub.ingestion.run.pipeline.PipelineInitError: Failed to configure the source (mongodb): Unknown option codec_options

@jonasHanhan jonasHanhan force-pushed the fix-python-datetime-of-mongodb-is-larger branch 2 times, most recently from 9bbccb0 to 4b7dec1 Compare April 3, 2024 07:36
@jonasHanhan jonasHanhan force-pushed the fix-python-datetime-of-mongodb-is-larger branch from 4b7dec1 to 6b6de74 Compare April 3, 2024 07:39
@hsheth2 hsheth2 merged commit 294b6d4 into datahub-project:master Apr 4, 2024
56 of 57 checks passed
@jonasHanhan jonasHanhan deleted the fix-python-datetime-of-mongodb-is-larger branch April 8, 2024 02:01
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@jonasHanhan @sleeperdeep
fix(ingestion/mongodb): MongoDB source unable to parse datetimes with…
8f785a3 
… years > 9999 (datahub-project#10110)

Co-authored-by: JonasHan <zengqh12>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees

@hsheth2 hsheth2

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MongoDB source unable to parse datetimes with years > 9999
2 participants
@jonasHanhan @hsheth2