feat: add storagehub pallets to all the runtimes#133
Merged
Conversation
undercover-cactus
changed the title
undercover-cactus
requested review from
ahmadkaouk,
gonzamontiel and
stiiifff
and removed request for
ahmadkaouk
Contributor
|
@coderabbitai review |
gonzamontiel
approved these changes
Sep 1, 2025
Contributor
gonzamontiel
left a comment
gonzamontiel
left a comment
There was a problem hiding this comment.
All seems good. I notice one thing though, and that is that the constants and values used like MostlyStablePrice, factors, etc, are likely configured either for production or testnet, and we may want to fine tune for the different runtimes, so it's secure on mainnet but easy to test on a stagenet. Just a thought because I don't have full context on those numbers.
stiiifff
approved these changes
Sep 2, 2025
stiiifff
added a commit
that referenced
this pull request
Sep 2, 2025
This PR add the storagehub pallets to the `testnet` and `mainnet` runtime. The storage hub pallets are only build with the runtime if the `storage-hub` feature is activated. It is also add minor fixes to the `stagenet` runtime (fix wrong path dependencies, index collision, etc...). --------- Co-authored-by: Steve Degosserie <723552+stiiifff@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the storagehub pallets to the
testnetandmainnetruntime. The storage hub pallets are only build with the runtime if thestorage-hubfeature is activated.It is also add minor fixes to the
stagenetruntime (fix wrong path dependencies, index collision, etc...).