feat: add output_bytes metrics#52
Merged
geoffreyclaude merged 1 commit intodatafusion-contrib:mainfrom May 6, 2026
Merged
Conversation
output_bytes metric was introduced here: apache/datafusion#18268. Added it and refreshed the other metrics using the script in the comment
geoffreyclaude
approved these changes
May 6, 2026
Collaborator
geoffreyclaude
left a comment
geoffreyclaude
left a comment
There was a problem hiding this comment.
This is a great fix, especially re-running the script. I really need to do a DataFusion upgrade checklist for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
output_bytes metric was introduced here:
apache/datafusion#18268. Added it and refreshed the other metrics using the script in the comment
Which issue does this PR close?
Rationale for this change
output_bytes is useful for debugging execution plans similar to output_rows
What changes are included in this PR?
Add output_bytes. Also ran the script in the comment to see if there were other metrics to add. Did not remove any metrics.
Are these changes tested?
Ran the tests in the repo which now produce output_bytes
Are there any user-facing changes?
Yes, but within the existing documentation