Fix SQLite Invalid column type Real error
#98
Merged
+31
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
commented
Sep 14, 2024
phillipleblanc
approved these changes
Sep 15, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed at Bug: SQLite acceleration fails with Invalid column type Real TPCH Q10 and Q19 the SQLite Table Provider was failing with the following error when attempting to read a Float value as an Integer. This issue occurs when a query returns the first row for a Float column with a value without a fractional component, which SQLite represents as an Integer.
The PR updated the schema inference to use the projected schema to accurately determine if the column is actually a Float.
Note: The error has a stable repro but occurs only in in-memory mode.