Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Re-attach databases on each DuckDB query #92

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix: Re-attach databases on each DuckDB query #92

merged 2 commits into from
Sep 10, 2024
+179 −32

Conversation

peasee
Copy link
Collaborator

@peasee peasee commented Sep 10, 2024

🗣 Description

  • Updates database attachments to be managed at the connection level, ensuring databases are always attached and catalog search path set for each query.

DuckDB's connection try_clone creates a new connection to the underlying instance. Because SET search_path can't be global, it resets when the new connection opens (also causing all database ATTACHments to reset).

@peasee peasee added the bug Something isn't working label Sep 10, 2024
@peasee peasee self-assigned this Sep 10, 2024
@peasee peasee changed the title fix: Re-attach databases on each query fix: Re-attach databases on each DuckDB query Sep 10, 2024
@phillipleblanc phillipleblanc merged commit 01bef67 into spiceai Sep 10, 2024
3 checks passed
@phillipleblanc phillipleblanc deleted the fix/reattach-databases-on-each-query branch September 10, 2024 13:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

@sgrebnov sgrebnov Awaiting requested review from sgrebnov

Assignees

@peasee peasee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peasee @phillipleblanc