Update query hook #208
Merged
Update query hook #208
+102
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we parse the sql, retain the parsed statement as well as the raw string and the plan. This is because we have upcoming cases where we want to reference the statement without needing to re-parse the query.
Add extended query support to QueryHook,. Also re-use the parsed statement instead of parsing it again because it is was wasted work, and it also made the code less clean. (We still potentially handle the params more than once, which can be fixed later) Finally, ensure the client is Send + Sync. (Should this be enforced in pgwire?)
|
Use of |
|
@mjgarton hey Martin, sqlparser is already reported from datafusion at |
sunng87
reviewed
Oct 9, 2025
Add handle_extended_parse_query to QueryHook so that parse phase operations can be processed.
sunng87
reviewed
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial extended query support in QueryHook, and some minor refactoring to support this. See individual commits for more detail.