Add session-level statement timeout support #153
Merged
+273
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iPeluwa
commented
Sep 10, 2025
iPeluwa
commented
- Implement SET statement_timeout with support for ms, s, min units
- Add SHOW statement_timeout to display current timeout setting
- Default to no timeout (disabled) - use SET statement_timeout = 0 to disable
- Timeout is per-session, not server-wide configuration
- Supports PostgreSQL standard syntax: SET statement_timeout = '30s'
- Query execution respects the session timeout in both simple and extended query protocols
- Added comprehensive tests for timeout setting, showing, and disabling
- Implement SET statement_timeout with support for ms, s, min units - Add SHOW statement_timeout to display current timeout setting - Default to no timeout (disabled) - use SET statement_timeout = 0 to disable - Timeout is per-session, not server-wide configuration - Supports PostgreSQL standard syntax: SET statement_timeout = '30s' - Query execution respects the session timeout in both simple and extended query protocols - Added comprehensive tests for timeout setting, showing, and disabling
- Fixed redundant closure warnings - Applied clippy pedantic suggestions - Improved code quality and consistency
sunng87
reviewed
Sep 10, 2025
…etadata - Remove statement_timeout field from DfSessionService (was application-scoped) - Store timeout in ClientInfo::metadata() using METADATA_STATEMENT_TIMEOUT key - Add helper functions get_statement_timeout() and set_statement_timeout() - Update SET/SHOW statement_timeout handlers to use client metadata - Update query execution logic to read timeout from client session - Add comprehensive MockClient for testing session-specific behavior - Now each PostgreSQL session has its own independent timeout setting This follows the PostgreSQL standard where statement_timeout is a session variable, not a server-wide configuration.
sunng87
approved these changes
Sep 10, 2025
sunng87
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.