Skip to content

refactor: optimise logicalplan before execution #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

refactor: optimise logicalplan before execution #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions datafusion-postgres/src/handlers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,8 +505,15 @@ impl ExtendedQueryHandler for DfSessionService {
let plan = plan
.clone()
.replace_params_with_values(&param_values)
.map_err(|e| PgWireError::ApiError(Box::new(e)))?; // Fixed: Use &param_values
let dataframe = match self.session_context.execute_logical_plan(plan).await {
.map_err(|e| PgWireError::ApiError(Box::new(e)))?; // Fixed: Use
// &param_values
let optimised = self
.session_context
.state()
.optimize(&plan)
.map_err(|e| PgWireError::ApiError(Box::new(e)))?;

let dataframe = match self.session_context.execute_logical_plan(optimised).await {
Ok(df) => df,
Err(e) => {
return Err(PgWireError::ApiError(Box::new(e)));
Expand Down Expand Up @@ -538,10 +545,7 @@ impl QueryParser for Parser {
.create_logical_plan(sql)
.await
.map_err(|e| PgWireError::ApiError(Box::new(e)))?;
let optimised = state
.optimize(&logical_plan)
.map_err(|e| PgWireError::ApiError(Box::new(e)))?;
Ok((sql.to_string(), optimised))
Ok((sql.to_string(), logical_plan))
}
}

Expand Down
Loading