Conversation
.github/workflows/ci.yml
Outdated
| with: | ||
| components: clippy | ||
| - run: cargo clippy --all-targets --features integration | ||
| - run: cargo clippy --all-targets --features integration -- -D warnings |
There was a problem hiding this comment.
🤔 I'm realizing something... I think this might not be getting applied to any of the tests behind the tpch, tpcds and clickbench features.
There was a problem hiding this comment.
Maybe we need to say something like --all-features?
There was a problem hiding this comment.
Yeah, from what I can tell clippy right now is only being applied to the integration feature.
Upstream, clippy in CI here looks like it runs this script, which ends up running
cargo clippy --all-targets --workspace --features avro,integration-tests,extended_tests -- -D warnings
so the -- -D warnings is definitely there, and it looks like they manually list out the features rather than using --all-features, presumably because there are so many features it could slow down CI. For us, I think --all-features could be a good idea. Thoughts?
There was a problem hiding this comment.
👍 yeap! lets go with that
2 participants
In #256, we noticed that some clippy warnings were not caught by CI. I've taken a look, and I believe the relevant line is here:
If we want the CI to fail on a clippy warning like for this print statement, seems like we have to change it to