Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip notebook cell outputs #1613

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Strip notebook cell outputs #1613

merged 3 commits into from
Dec 12, 2023

Conversation

Ekrekr
Copy link
Contributor

@Ekrekr Ekrekr commented Dec 12, 2023

No description provided.

@Ekrekr Ekrekr requested a review from a2wd December 12, 2023 11:54
// TODO(ekrekr): base64 encode the notebook as a string instead.
return `exports.asBase64String = () => \`${JSON.stringify(notebookAsJson)})\``;
return `exports.asBase64String = () => \`${JSON.stringify(notebookAsJson)}\``;

Check warning

Code scanning / CodeQL

Improper code sanitization Medium

Code construction depends on an
improperly sanitized value
.
@Ekrekr Ekrekr merged commit 13787c4 into main_v3 Dec 12, 2023
4 checks passed
@Ekrekr Ekrekr deleted the strip-notebook-outputs branch December 12, 2023 12:20
moker-spaghetti pushed a commit to moker-spaghetti/dataform that referenced this pull request May 26, 2024
* Strip notebook outputs

* Tidy

* Fix tslint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants