✨ Intégrer OpenStreetMap fourni par Protomaps #61
+409
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔥 Remove Leva which was used for the demo
This reverts commit 599f7b5.
jereze
reviewed
Feb 23, 2025
webapp/package.json
Outdated
| @@ -3,17 +3,21 @@ | |||
| "version": "0.1.0", | |||
| "private": true, | |||
| "scripts": { | |||
| "dev": "next dev --turbopack", | |||
| "dev": "next dev", | |||
There was a problem hiding this comment.
Tu as raison ! Il y avait un problème avec react-map-gl que j'avais besoin de personnaliser avec webpack. Après avoir changé la version, ce n'est plus nécessaire.
jereze
reviewed
Feb 23, 2025
webapp/package.json
Outdated
| "build": "next build", | ||
| "start": "next start", | ||
| "lint": "next lint" | ||
| }, | ||
| "dependencies": { | ||
| "@duckdb/node-api": "^1.1.3-alpha.12", | ||
| "maplibre-gl": "^5.0.1", | ||
| "leva": "^0.10.0", |
There was a problem hiding this comment.
on va utiliser shadcn, on peut l'enlever ?
There was a problem hiding this comment.
en tous cas, cela génère des conflits lors d'un npm install
jereze
reviewed
Feb 23, 2025
webapp/app/config.ts
Outdated
| export const MAPLIBRE_MAP = { | ||
| protomaps: { | ||
| // https://protomaps.com/api | ||
| api_key: "707d8bc70b393fc0", |
There was a problem hiding this comment.
On voudra utiliser une env variable
This was referenced Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexte
Auparavant, nous disposions des PR pour explorer le fond ou le type de fond des cartes que nous souhaitions utiliser :
Nous avons décidé d'utiliser OpenStreetMap fourni par Protomaps qui sert de fond de carte en utilisant PMTiles pour fournir une expérience de réseau fluide et aussi beaucoup d'options de personnalisation.
Changements