Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Measurement Faker #194

Merged
merged 1 commit into from
May 30, 2022

Conversation

Tahanima
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #194 (da89e97) into master (380d21f) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #194      +/-   ##
============================================
- Coverage     94.81%   94.70%   -0.12%     
- Complexity     1787     1794       +7     
============================================
  Files           181      182       +1     
  Lines          3781     3793      +12     
  Branches        377      377              
============================================
+ Hits           3585     3592       +7     
- Misses          102      104       +2     
- Partials         94       97       +3     
Impacted Files Coverage Δ
.../main/java/net/datafaker/service/files/EnFile.java 93.33% <ø> (ø)
src/main/java/net/datafaker/Faker.java 99.50% <100.00%> (+<0.01%) ⬆️
src/main/java/net/datafaker/Measurement.java 100.00% <100.00%> (ø)
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️
.../java/net/datafaker/service/FakeValuesService.java 88.17% <0.00%> (-0.65%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Tahanima
Copy link
Contributor Author

@bodiam, net.datafaker.PhoneNumberTest.testAllCellPhone_enUS test is failing.

@bodiam
Copy link
Contributor

bodiam commented May 30, 2022

@Tahanima yeah, seems like we still have a flaky tests here somewhere. Your PR looks good though, so lets just merge it, the us phone number we'll fix later! Thanks again!

@bodiam bodiam merged commit 474401f into datafaker-net:master May 30, 2022
@Tahanima Tahanima deleted the feature/add-measurement-faker branch May 30, 2022 14:21
@Tahanima
Copy link
Contributor Author

@Tahanima yeah, seems like we still have a flaky tests here somewhere. Your PR looks good though, so lets just merge it, the us phone number we'll fix later! Thanks again!

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants