Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move India country-specific settings to file "_IN.yml" #1379

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

asolntsev
Copy link
Collaborator

@asolntsev asolntsev commented Oct 15, 2024

these are valid in all languages, not only in English.

NB! Rename "IND" to "IN" because this is the valid 2-letter India country code.

@sann3 FYI

@asolntsev asolntsev self-assigned this Oct 15, 2024
Copy link

what-the-diff bot commented Oct 15, 2024

PR Summary

  • Clarifying Language in the README
    The README file was updated to provide more precise information on the language support. "en-IND" was changed to "en-IN (India)" to be more descriptive.

  • Added Indian Localization Support
    A new YAML file (_IN.yml) was added specifically for the Indian users. This file includes localized data such as proper address formats used in India and their respective timezones, typical Indian internet practices like widely-used email providers and domain suffixes, and phone number formats that are specific to India.

  • Renaming and Updating Previous YAML File
    The existing file en-IND.yml was renamed to en-IN.yml. This file was also updated where redundant fields (like 'address postcode' and 'timezone') were removed. These data are now available in the newly created _IN.yml, optimizing data management and improving overall functionality.

@asolntsev asolntsev added the enhancement New feature or request label Oct 15, 2024
kingthorin
kingthorin previously approved these changes Oct 15, 2024
@kingthorin kingthorin dismissed their stale review October 15, 2024 06:14

Per tests something was missed as part of this update

these are valid in all languages, not only in English.

NB! Rename "IND" to "IN" because this is the valid 2-letter India country code.
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (6df5626) to head (02864e2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1379      +/-   ##
============================================
- Coverage     92.44%   92.34%   -0.10%     
+ Complexity     3149     3147       -2     
============================================
  Files           319      319              
  Lines          6178     6178              
  Branches        604      604              
============================================
- Hits           5711     5705       -6     
- Misses          324      328       +4     
- Partials        143      145       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kingthorin
Copy link
Collaborator

Thanks!

@kingthorin kingthorin merged commit e5f46e5 into main Oct 15, 2024
11 of 12 checks passed
@kingthorin kingthorin deleted the refactor/india branch October 15, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants