Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid validation of existing providers #474

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

kjgarza
Copy link
Contributor

@kjgarza kjgarza commented Oct 23, 2020

Purpose

Validation of provider check if the symbol is unique even when the provider is being updated. This causes an error on updating providers.

closes: #463

Approach

Avoid validation of uniqueness for existent records.

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@kjgarza kjgarza self-assigned this Oct 23, 2020
Copy link
Contributor

@mfenner mfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjgarza kjgarza merged commit 193aa07 into master Oct 26, 2020
@kjgarza kjgarza deleted the fix_validation_provider branch October 26, 2020 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to update newly created member accounts
2 participants