Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send logged in user to settings #468

Merged
merged 4 commits into from
Oct 5, 2020
Merged

send logged in user to settings #468

merged 4 commits into from
Oct 5, 2020

Conversation

kjgarza
Copy link
Contributor

@kjgarza kjgarza commented Sep 29, 2020

Purpose

send logged in user to settings
Consortium Lead, Consortium Orgs, Direct Members and Repositories should land on Settings tab when logging in to Fabrica.

closes: #467

Approach

reverses #362 for consortium organisations

Open Questions and Pre-Merge TODOs

Learning

In order to save new recording in polly one needs to change the mode to

    mode: 'record',

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

reverse #362 for consortium organisations
@kjgarza kjgarza self-assigned this Sep 29, 2020
@mfenner
Copy link
Contributor

mfenner commented Sep 30, 2020

@kjgarza please explain why you change the intentional redirection to the list of consortium organizations when consortium accounts log in. The reasoning was that this is what consortium accounts mostly do, manage consortium organizations.

@mfenner
Copy link
Contributor

mfenner commented Sep 30, 2020

Also, the pull request is not addressing #467.

@kjgarza
Copy link
Contributor Author

kjgarza commented Sep 30, 2020

@MaryHirsch could you help us to confirm this?. I thought it was confirmed this behaviour was a bug

@mfenner
Copy link
Contributor

mfenner commented Sep 30, 2020

@kjgarza this was not confirmed to be a bug. I said "Sound like a bug that needs investigating." and on further investigation was not a bug.

@kjgarza kjgarza marked this pull request as draft October 1, 2020 07:16
@kjgarza kjgarza requested review from mfenner and removed request for richardhallett October 2, 2020 09:59
@kjgarza kjgarza marked this pull request as ready for review October 2, 2020 10:05
@mfenner mfenner changed the title send logged user to settings send logged in user to settings Oct 5, 2020
Copy link
Contributor

@mfenner mfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjgarza kjgarza merged commit 5b0a959 into master Oct 5, 2020
@kjgarza kjgarza deleted the fix_route_consortium branch October 5, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging into Fabrica with consortium organization account directs user to repositories tab
2 participants