feat: force all the dois updated with the form to become schema 4

[kjgarza]

Purpose

Forces all DOIs updated in the form to become schema 4.

closes: #447

Approach

All DOIs updated in the form will be transformed to schema 4. Independently of the state of the DOI (draft, registered, findable)

Learning

Looking back at the form support messages it can be seen that the form has not support schema transformation on the past. See https://app.frontapp.com/open/msg_29opdsb from 2019 ,which is related to datacite/datacite#654

This most likely due to the form modifying the metadata fields. The schema version is not a metadata field.

Status

• Ready for Review

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[richardhallett]

So what will happen in the scenario of older schema version with missing data, the form should fail to submit because it will be missing required fields right? and therefore once they fill it in, it will be valid schema 4?

[mfenner]

Can't review as I am on vacation.

[kjgarza]

its mostly an FYI @mfenner .

@richardhallett yeah, in that case, it will fail until they fill all the fields correctly.

[mfenner]

LGTM. It would be good if the form would show a warning message if you open a DOI using a schema version < 4.

[kjgarza]

unrelated test are failing because DOIs already exist (422) which doesn't make sense. This might be related to datacite/lupo#606. and it happening even with the master branch and the last release. This needs be fixed to merge.