Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change not found message for researcher profile #423

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

kjgarza
Copy link
Contributor

@kjgarza kjgarza commented Jun 3, 2020

Purpose

change the error message when a we find not resources for a given ORCID.

Approach

Display a more informative message for researcher profile visitor.

Open Questions and Pre-Merge TODOs

none

Learning

none

Status

  • Ready for Review

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@kjgarza kjgarza self-assigned this Jun 3, 2020
@kjgarza kjgarza requested a review from mfenner June 3, 2020 17:29
Copy link
Contributor

@mfenner mfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • why only datasets?
  • what is the course of action? I suggest we send the user to a support page that describes the workflow (auto-update and search and link).

@kjgarza
Copy link
Contributor Author

kjgarza commented Jun 4, 2020

@mfenner

why only datasets?

visitors of the researcher profile (which are, probably, about the only visitors of that page) are expecting to see datasets. I do not hold a strong position, i can write doi or resources; We just need to change the message because it says that The Researcher Profile/Fabrica is down when is not.

what is the course of action? I suggest we send the user to a support page that describes the workflow (auto-update and search and link).

This is precisely my question in slack. I can add the link in the message but, considering the discussion in the #parsec channel in slack(only DOIs metadata with ORCIDs will be displayed), understanding the workflow won't make any difference to the final user, unless the search and link claims are included in the Researcher Profile (or PID graph).

@mfenner
Copy link
Contributor

mfenner commented Jun 4, 2020

  • please use content as the term rather than datasets
  • please send users to DataCite Support
  • please work with Mary to update the support documentation. Specifically that claims via search & link are currently not included, but will in the future

@kjgarza kjgarza requested a review from mfenner June 10, 2020 07:08
Copy link
Contributor

@mfenner mfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjgarza kjgarza merged commit 111e990 into master Jun 15, 2020
@kjgarza kjgarza deleted the docs_change_meesage_404 branch June 15, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants