Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 enable setting values for when name-type is not defined/unk… #410

Merged
merged 2 commits into from
May 11, 2020
Merged

fix: 🐛 enable setting values for when name-type is not defined/unk… #410

merged 2 commits into from
May 11, 2020

Conversation

kjgarza
Copy link
Contributor

@kjgarza kjgarza commented May 11, 2020 •
edited
Loading

…nown

resolves: #408

mfenner
mfenner approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@mfenner mfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjgarza kjgarza merged commit a981308 into master May 11, 2020
@kjgarza kjgarza self-assigned this May 11, 2020
@mfenner mfenner deleted the fix_bug_nametye_unknown branch February 3, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfenner mfenner mfenner approved these changes

Assignees

@kjgarza kjgarza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting Creator name-Type to 'unknown' deletes GiveName and LastName in metadata
2 participants
@kjgarza @mfenner