Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests covering all models #354

Merged
merged 11 commits into from
Mar 3, 2020
Merged

Tests covering all models #354

merged 11 commits into from
Mar 3, 2020

Conversation

sarala
Copy link
Contributor

@sarala sarala commented Mar 3, 2020

I have created tests for all models which tests for existence of the models and computed values.

@sarala sarala requested a review from mfenner March 3, 2020 09:31
Copy link
Contributor

@mfenner mfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with repositoryList instead of repositoryCount.

Going forward I would expand some of the tests.

LGTM

@sarala sarala merged commit fd99805 into master Mar 3, 2020
@sarala
Copy link
Contributor Author

sarala commented Mar 3, 2020

@mfenner, which ones would you like to see extended?

@mfenner
Copy link
Contributor

mfenner commented Mar 3, 2020

@sarala nothing urgent, but some tests are more or less boilerplate code.

@sarala
Copy link
Contributor Author

sarala commented Mar 3, 2020

@mfenner, I mainly did two things:

  1. tests for computed variables
  2. test model exist (boilerplate code) where there are no computed variables. There is nothing else to test in those models. However, it had no impact on codeclimate coverage.

@mfenner
Copy link
Contributor

mfenner commented Mar 3, 2020

One example would be the test for organization abilities. There are various user roles and various abilities.

@sarala
Copy link
Contributor Author

sarala commented Mar 4, 2020

I thought you do that in abilities unit tests rather than model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants