-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests covering all models #354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with repositoryList instead of repositoryCount.
Going forward I would expand some of the tests.
LGTM
@mfenner, which ones would you like to see extended? |
@sarala nothing urgent, but some tests are more or less boilerplate code. |
@mfenner, I mainly did two things:
|
One example would be the test for organization abilities. There are various user roles and various abilities. |
I thought you do that in abilities unit tests rather than model. |
I have created tests for all models which tests for existence of the models and computed values.