Form disable meta

[richardhallett]

For #132

[mfenner]

You could set a default in line 4.

export default Component.extend({
  metadataFieldsDisabled: true,

  didReceiveAttrs() {
    if (this.model.get("source") == "fabricaForm") {
      this.set('metadataFieldsDisabled', false);
    }

[mfenner]

Why is there a doi-form component. It seems to add complexity.

[richardhallett]

Why is there a doi-form component. It seems to add complexity.

Because we need specific functionality that applies to the form, this seemed a logical way to encapsulate the behaviour of the metadata form fields separate to that of other parts.
Do you have another suggestion of where to put the logic around deciding if the form elements should be disabled or not?

[mfenner]

@richardhallett the form is displayed in four slightly different versions: new/edit and form/file upload. We need to disable the form in only one of them (edit form). So it would make sense for me to put that logic into the template for edit form: https://github.com/datacite/bracco/blob/master/app/templates/clients/show/dois/show/edit.hbs

[richardhallett]

@richardhallett the form is displayed in four slightly different versions: new/edit and form/file upload. We need to disable the form in only one of them (edit form). So it would make sense for me to put that logic into the template for edit form: https://github.com/datacite/bracco/blob/master/app/templates/clients/show/dois/show/edit.hbs

The usage of the field could be in that I suppose, but given I needed to set the metadataFieldsDisabled this seemed best to put it in component code which is where the backing of doi-form.js comes in? Where instead would you put that in place, create a backend component logic for the show/edit.js?

[mfenner]

@richardhallett you can also do this directly when you create the DOI, i.e. start with defaults.