Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to navigate to DOIs tab #396

Closed
MaryHirsch opened this issue Apr 9, 2020 · 1 comment
Closed

Not possible to navigate to DOIs tab #396

MaryHirsch opened this issue Apr 9, 2020 · 1 comment
Assignees
Labels

Comments

@MaryHirsch
Copy link

MaryHirsch commented Apr 9, 2020

Expected Behaviour

DOIs listed under DOIs tab

Current Behaviour

For some accounts the DOIs are not listed https://doi.test.datacite.org/providers/osi

Steps to Reproduce

  1. Example https://doi.test.datacite.org/providers/osi

Context (Environment)

Fabrica test

Hypothesis

Detailed Description

Possible Implementation

Front logo Front conversations

@mfenner mfenner self-assigned this Apr 16, 2020
@mfenner mfenner added the bug label Apr 17, 2020
@mfenner
Copy link
Contributor

mfenner commented Apr 17, 2020

This issue is caused by repeatable DOI metadata fields not always being an array in the REST API, in this case the dates field. This issue comes up now as Fabrica is actually using these fields in the DOI form, using a fragmentArray. This is the error we can see in the console.

The short-term fix is to always serialize these fields into an array in the DOI serializer in the API. The long-term fix (faster, but needs updating all DOI records and reindexing) is to make sure these fields are always stored in the database (where we use a JSON field) as an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants