Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTP links not accepted in url field in file upload and form in Fabrica #300

Closed
MaryHirsch opened this issue Jan 24, 2020 · 3 comments
Closed

FTP links not accepted in url field in file upload and form in Fabrica #300

MaryHirsch opened this issue Jan 24, 2020 · 3 comments
Assignees
@mfenner
Labels
bug
Milestone
Week 3 2020

Comments

@MaryHirsch
Copy link

Expected Behaviour

ftp links accepted in url field in form and file upload

Current Behaviour

entering an ftp link in url field generates error

Steps to Reproduce

  1. enter ftp://ftp.library.noaa.gov/noaa_documents.lib/2013%20NOAA%205%20Year%20Plan_FINAL%20version.pdf in url field

Context (Environment)

Fabrica test and production

Hypothesis

Detailed Description

Possible Implementation
@MaryHirsch MaryHirsch added the bug label Jan 24, 2020
@MaryHirsch MaryHirsch self-assigned this Jan 24, 2020
@MaryHirsch MaryHirsch removed the bug label Jan 24, 2020
@MaryHirsch MaryHirsch assigned mfenner and unassigned MaryHirsch Jan 24, 2020
@MaryHirsch MaryHirsch added the bug label Jan 24, 2020
mfenner pushed a commit that referenced this issue Jan 25, 2020
use validator library for validations. #300
7775996
mfenner pushed a commit that referenced this issue Jan 25, 2020
use validator library for string validations. #300
17dc1ba
mfenner pushed a commit that referenced this issue Jan 25, 2020
tweak validation options. #300
d63f409
mfenner pushed a commit that referenced this issue Jan 25, 2020
cleanup of tests. #300
c62d951
@mfenner mfenner added this to the Week 3 2020 milestone Jan 25, 2020
@mfenner mfenner closed this as completed Jan 25, 2020
@MaryHirsch MaryHirsch reopened this Jan 29, 2020
@MaryHirsch
Copy link
Author

deploy to production

@richardhallett
Copy link
Contributor

Bracco was deployed to production but this appears to still be an issue occurring in production.

@richardhallett
Copy link
Contributor

Working now, deployment problem prevented fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfenner mfenner

Labels
bug
Projects
None yet
Milestone
Week 3 2020
Development

No branches or pull requests
3 participants
@mfenner @richardhallett @MaryHirsch