Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Fabrica Provider Settings form with contact information #195

Closed
kjgarza opened this issue May 13, 2019 · 10 comments
Closed

Update Fabrica Provider Settings form with contact information #195

kjgarza opened this issue May 13, 2019 · 10 comments
Assignees
@richardhallett

Comments

@kjgarza
Copy link
Contributor

kjgarza commented May 13, 2019

https://datacite.atlassian.net/wiki/spaces/TEC/pages/874577924/Collecting+and+displaying+member+information
@kjgarza kjgarza mentioned this issue May 14, 2019
Closed
@richardhallett
Copy link
Contributor

The form has been updated based upon the mockups.
The only change I can see that I have not missed in the separation between general contact and fabrica password email.
I believe they are one in the same and think this will make things simpler.

@mfenner
Copy link
Contributor

mfenner commented May 23, 2019

Feedback: only show provider form section titles (like Billing Information) when there is information.
Bildschirmfoto 2019-05-23 um 15 38 14

@mfenner
Copy link
Contributor

mfenner commented May 23, 2019 •
edited
Loading

Feedback: use appropriate labels (e.g. Billing Contact Given Name instead of Billing Given Name).

Bildschirmfoto 2019-05-23 um 15 40 11

@mfenner
Copy link
Contributor

mfenner commented May 23, 2019

Feedback: fix error message.
Bildschirmfoto 2019-05-23 um 15 42 16

@mfenner
Copy link
Contributor

mfenner commented May 23, 2019 •
edited
Loading

Feedback: Spelling (use Twitter instead of twitter).
Bildschirmfoto 2019-05-23 um 15 44 02

@mfenner
Copy link
Contributor

mfenner commented May 23, 2019

Feedback: properly left-align heading.
Bildschirmfoto 2019-05-23 um 15 55 15

@mfenner
Copy link
Contributor

mfenner commented May 23, 2019

Feedback: is secondary billing contact optional or required?

@richardhallett
Copy link
Contributor

Updates

  • Twitter spelling changed
  • Twitter validation error message update
  • Secondary Billing contact is optional - Added text to fit.
  • Updated billing contact field names to reflect other contacts.
  • Added title for organization information section
  • Moved titles left justfied aligned
  • Only showing billing heading on overview if it has data
  • Re-ordered billing contact fields

richardhallett added a commit that referenced this issue May 23, 2019
@richardhallett
Integrate feedback for provider form layout changes
5ea4db7 
* Twitter spelling changed
* Twitter validation error message update
* Secondary Billing contact is optional - Added text to fit.
* Updated billing contact field names to reflect other contacts.
* Added title for organization information section
* Moved titles left justfied aligned
* Only showing billing heading on overview if it has data
* Re-ordered billing contact fields

Ref #195
mfenner pushed a commit to datacite/lupo that referenced this issue May 23, 2019
don't validate contact information. datacite/bracco#195
576d23f
mfenner pushed a commit that referenced this issue May 23, 2019
show ror_id as link. #195
e2de32e
mfenner pushed a commit that referenced this issue May 23, 2019
use single regex for twitter. #195
a34b534
mfenner pushed a commit that referenced this issue May 23, 2019
show twitter account as url. #195
fcc6d2b
mfenner pushed a commit that referenced this issue May 23, 2019
fix form typo. #195
d058087
@mfenner
Copy link
Contributor

mfenner commented May 23, 2019 •
edited
Loading

Updates from me

  • show ROR ID as clickable link
  • use only one regex to validate Twitter account
  • show Twitter account as clickable link
  • don't validate additional contact information
  • contact email after givenName and familyName
  • properly display "billing information not provided"
  • left-align categories in "create provider" form
  • correctly display general contact info

@mfenner
Copy link
Contributor

mfenner commented May 23, 2019

Simplified display of contact information.

Bildschirmfoto 2019-05-23 um 23.13.08.png

mfenner pushed a commit that referenced this issue May 23, 2019
simplified display of contact information. #195
ef486f1
mfenner pushed a commit that referenced this issue May 23, 2019
don't use html validation. #195
822b4c1
mfenner pushed a commit that referenced this issue May 23, 2019
correctly display general contact info. #195
109f86a
mfenner pushed a commit that referenced this issue May 24, 2019
fix display of ror_id. #195
0fc9f10
mfenner pushed a commit to datacite/lupo that referenced this issue May 24, 2019
use role_member with provider. datacite/bracco#195
89e8b00
mfenner pushed a commit that referenced this issue May 24, 2019
fixed ror_id display. #195
c053af3
mfenner pushed a commit that referenced this issue May 24, 2019
change label for ror_id lookup. #195
c1c09fd
mfenner pushed a commit that referenced this issue May 24, 2019
allow providers to edit organization type and focus area. #195
206520d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardhallett richardhallett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mfenner @kjgarza @richardhallett