DOI Upload file is validating DOI name on update

[kjgarza]

DOI name shoun'dt be validated on update. Old DOI name might contain values we do not accept anymore.

It seems to be that this is happening in the DOI upload

https://usersnap.com/a/#/datacite/p/datacite-41ebcc0f/581

Front conversations

[kjgarza]

So description is being validated with /dois/validate which will send an error if the DOI has a + sign

bracco/app/validators/metadata.js

Line 14 in 9df40ec

let url = ENV.API_URL + '/dois/validate';

[mfenner]

Where is the validation creating an error for a DOI with a + sign?

[kjgarza]

the API call to /dois/validate is returning

 {source: "doi", title: "Is invalid"}

The request is taking the DOI-name from the DOI model and although it cannot be modified it still has the + sign. So basically is failing in Lupo when one wants to validate metadata with a DOI-name with a + sing

[kjgarza]

I just noticed that there is a flag in lupo.

unless: :only_validate

Alternatevely maybe we could skip doi-name validation on /dois/validate

https://github.com/datacite/lupo/blob/96a6c2c113f349128d5700c1cd0a224522dbd45c/app/models/doi.rb#L80

  validates_format_of :doi, :with => /\A10\.\d{4,5}\/[-\._;()\/:a-zA-Z0-9\*~\$\=]+\z/, :on => :create

would that be better ??

[mfenner]

I think you are saying to not check the DOI format when you are validating a DOI that you want to update. Which makes perfect sense to me. We still need the DOI check for the validation of a new DOI.

[mfenner]

@kristian I think there are two scenarios:

• DOI exists -> validation of metadata with DOI name containing a + sign should pass
• DOI does not exist -> validation of metadata with DOI name containing a + sign should fail

In the current implementation both would fail, in your proposed implementation both would pass.

The easiest way to implement this might be to first check for existence of DOI record in validate method in dois controller.

[kristian]

@mfenner, wrong @kristian... guess you meant @kjgarza

[mfenner]

Sorry, of course. Have a nice weekend.