Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change layout of creator form field #170

Closed
3 tasks done
mfenner opened this issue Mar 27, 2019 · 1 comment
Closed
3 tasks done

Change layout of creator form field #170

mfenner opened this issue Mar 27, 2019 · 1 comment
Assignees
@mfenner

Comments

@mfenner
Copy link
Contributor

mfenner commented Mar 27, 2019 •
edited
Loading

  • GivenName and FamilyName should not be labeled as optional
  • Greyed out name box for personal names should be below givenName and familyName and better indicate that it is not an input field
  • Make sure a good part of the creator field is above the fold
@mfenner mfenner self-assigned this Mar 27, 2019
@mfenner
Copy link
Contributor Author

mfenner commented Mar 30, 2019 •
edited
Loading

givenName and familyName are indeed optional, you need at least one of the two. As researchers with only given or family name are an edge case, we will remove the optional label.

mfenner pushed a commit that referenced this issue Mar 30, 2019
improve creator form. #174 #180 #170
efe51ae
mfenner pushed a commit that referenced this issue Mar 30, 2019
handle name identifier errors. #170 #174 #180
239966e
@mfenner mfenner closed this as completed Mar 30, 2019
mfenner pushed a commit that referenced this issue Mar 31, 2019
change layout and linking between fields. #170
d0f6162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfenner mfenner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mfenner