BEP341 & BEP402 #52
Merged
BEP341 & BEP402 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 26, 2024 17:02
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
added 5 commits
July 23, 2024 19:51
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
added 2 commits
July 24, 2024 09:53
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
yoshidan
force-pushed
the
feature/bep-341-1
branch
from
073f713
to
104e135
Compare
added 5 commits
July 25, 2024 19:06
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
Signed-off-by: Naohiro Yoshida <[email protected]>
yoshidan
commented
Jul 29, 2024
| @@ -105,6 +113,32 @@ impl ETHHeader { | |||
| stream.append(&self.extra_data[..self.extra_data.len() - EXTRA_SEAL].to_vec()); | |||
| stream.append(&self.mix_digest); | |||
| stream.append(&self.nonce); | |||
| if let Some(parent_beacon_root) = &self.parent_beacon_root { | |||
There was a problem hiding this comment.
Calculation of the seal hash according to BEP-402
yoshidan
commented
Jul 29, 2024
| let start = EXTRA_VANITY + VALIDATOR_NUM_SIZE; | ||
| let end = start + num * VALIDATOR_BYTES_LENGTH; | ||
| let turn_length = extra_data[end]; | ||
| if !(turn_length == 1 || (3..=9).contains(&turn_length)) { |
There was a problem hiding this comment.
According to 424-governable-number-of-consecutive-blocks
currently, the range for the value of n is set to [1,9] but except 2.
yoshidan
commented
Jul 29, 2024
|
|
||
| impl Epoch { | ||
| pub fn new(validator_set: ValidatorSet, turn_length: u8) -> Self { | ||
| let seed = [[turn_length].as_slice(), validator_set.hash.as_slice()].concat(); |
There was a problem hiding this comment.
Save this hash as a validator hash in the cons state.
yoshidan
commented
Jul 29, 2024
|
|
||
| pub struct Localnet; | ||
|
|
||
| impl Network for Localnet { |
There was a problem hiding this comment.
Test data can be prepared for each network for future HF support. Currently, Bohr is only operating on the localnet, so the test data is for the localnet only.
We will increase the corresponding test data once it is deployed on the testnet and mainnet.
Signed-off-by: Naohiro Yoshida <[email protected]>
3100
reviewed
Aug 13, 2024
Signed-off-by: Naohiro Yoshida <[email protected]>
BEP-341 4.2.1 Priority Allocation
Signed-off-by: Naohiro Yoshida <[email protected]>
3100
approved these changes
Aug 14, 2024
yoshidan
added a commit
that referenced
this pull request
Aug 14, 2024
support bep-341 & bep-342 Signed-off-by: Naohiro Yoshida <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/bnb-chain/BEPs/blob/master/BEPs/BEP-341.md
https://github.com/bnb-chain/BEPs/blob/master/BEPs/BEP-402.md