Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update README for cross docs explanation #2

Merged
merged 21 commits into from
Apr 26, 2022
Merged

[WIP] Update README for cross docs explanation #2

merged 21 commits into from
Apr 26, 2022

Conversation

hiromaily
Copy link
Contributor

@hiromaily hiromaily commented Apr 4, 2022 •
edited
Loading

  • adding information for cross framework tutorial using this repository on cross docs
  • tweak Dockerfile due to failure on CI

How Readmes look like

resolve: #1

@hiromaily hiromaily changed the title add directory structure [WIP] add directory structure Apr 4, 2022
@hiromaily hiromaily self-assigned this Apr 4, 2022
@hiromaily
Copy link
Contributor Author

hiromaily commented Apr 4, 2022 •
edited
Loading

error occurred when building Dockerfile on tendermint

 => ERROR [scaffold-initializer 2/6] RUN apk add --no-cache jq=1.6-r1 bash=5.1.0-r0                                                                                                                    2.4s
------
 > [scaffold-initializer 2/6] RUN apk add --no-cache jq=1.6-r1 bash=5.1.0-r0:
#10 1.114 fetch https://dl-cdn.alpinelinux.org/alpine/v3.13/main/x86_64/APKINDEX.tar.gz
#10 1.550 fetch https://dl-cdn.alpinelinux.org/alpine/v3.13/community/x86_64/APKINDEX.tar.gz
#10 2.205 ERROR: unable to select packages:
#10 2.275   bash-5.1.16-r0:
#10 2.275     breaks: world[bash=5.1.0-r0]

Done

@hiromaily hiromaily changed the title [WIP] add directory structure [WIP] Update README for cross docs explanation Apr 4, 2022
@hiromaily hiromaily mentioned this pull request Apr 4, 2022
Merged
@hiromaily hiromaily force-pushed the add-more-info branch 3 times, most recently from f54aa19 to 3633274 Compare April 11, 2022 06:20
@hiromaily
Copy link
Contributor Author

hiromaily commented Apr 11, 2022 •
edited
Loading

Github Action needs to be fixed due to this issue golangci/golangci-lint-action#442
Latest go is used automatically under no configuration.

run golangci-lint
  Running [/home/runner/golangci-lint-1.45.2-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=cmds/alpha] in [/home/runner/work/fabric-tendermint-cross-demo/fabric-tendermint-cross-demo/cmds/alpha] ...
  level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"io/fs\""

issue reported golangci/golangci-lint-action#448

Done

@hiromaily hiromaily force-pushed the add-more-info branch 8 times, most recently from d8b66b8 to 1f2e236 Compare April 11, 2022 10:04
@hiromaily hiromaily force-pushed the add-more-info branch 3 times, most recently from 4075e42 to 83312a5 Compare April 15, 2022 05:39
@hiromaily hiromaily requested review from mattsu6666 and 3100 April 18, 2022 01:41
3100
3100 reviewed Apr 22, 2022
View reviewed changes
Copy link
Member

@3100 3100 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiromaily
Thanks for the work!
I commented on the English version, but please do the same for the corresponding Japanese version when you modify them.

@3100 3100 merged commit 5674916 into main Apr 26, 2022
3100 added a commit that referenced this pull request Apr 26, 2022
@3100
Revert "[WIP] Update README for cross docs explanation (#2)"
85e34e5 
This reverts commit 5674916.
@3100 3100 deleted the add-more-info branch April 26, 2022 08:01
hiromaily added a commit that referenced this pull request Apr 27, 2022
@hiromaily
Update README for cross docs explanation (#2)
c573acc 
* add directory structure

* tweak Dockerfile due to CI detects error

* add basic explanation

* add readme for contracts/erc20

* add README.md for demo, fabric  directories

* upgrade golangci-lint-action to v3 due to errors in github action

* temporarily comment out golangci on github action

* fix explanation of command

* add more explanation about application

* add CLI explanation

* add setup for demo in demo Readme

* add explanation about sample scenario

* tweak link path

* add explanation of scenario

* add deployment in detail

* tweak golangci lint in github action

* tweak github action due to duplicative actions

* add more info pointed out

* add more info pointed out 2

* fix typo and mistakes

* format by vscode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3100 3100 3100 approved these changes

@mattsu6666 mattsu6666 Awaiting requested review from mattsu6666

Assignees

@hiromaily hiromaily

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update README for cross docs explanation
2 participants
@hiromaily @3100