Skip to content

Conversation

@ilongin
Copy link
Contributor

@ilongin ilongin commented Sep 13, 2025

Added docs for delete_namespace and fix current docs formatting.

Summary by Sourcery

Add documentation for the delete_namespace function in the namespaces guide, including its signature, behavior, and usage examples, and correct existing formatting issues.

Enhancements:

  • Fix formatting inconsistencies in the namespaces guide

Documentation:

  • Document the delete_namespace function with details on removing empty namespaces or projects
  • Include the function signature, parameter descriptions, and behavior constraints
  • Add usage examples demonstrating namespace and project deletion

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 13, 2025

Reviewer's Guide

This PR updates the namespaces guide by closing an unclosed code block and appending comprehensive documentation for the delete_namespace function, including its signature, usage rules, and examples.

File-Level Changes

Change Details Files
Corrected documentation code block formatting
  • Closed the existing code snippet with ```
  • Inserted a blank line before the new section
docs/guide/namespaces.md
Added documentation for delete_namespace
  • Introduced “Removing Namespaces and Projects” section
  • Defined the delete_namespace signature and behavior
  • Outlined deletion rules for namespaces and projects
  • Provided usage examples
docs/guide/namespaces.md

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ilongin ilongin linked an issue Sep 13, 2025 that may be closed by this pull request
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 13, 2025

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0faaf95
Status: ✅  Deploy successful!
Preview URL: https://573c9782.datachain-documentation.pages.dev
Branch Preview URL: https://ilongin-1338-namespaces-docs.datachain-documentation.pages.dev

View logs

```

- **`<namespace>`** — deletes the namespace (must contain no projects or datasets)
- **`<namespace>.<project>`** — deletes the project (must contain no datasets)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the layout (periods), etc

@codecov
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.57%. Comparing base (21e7e09) to head (0faaf95).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1339   +/-   ##
=======================================
  Coverage   87.57%   87.57%           
=======================================
  Files         156      156           
  Lines       14502    14502           
  Branches     2083     2083           
=======================================
  Hits        12700    12700           
  Misses       1331     1331           
  Partials      471      471           
Flag Coverage Δ
datachain 87.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/datachain/__init__.py 100.00% <100.00%> (ø)
src/datachain/lib/namespaces.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shcheklein
Copy link
Contributor

@ilongin tests fail

@amritghimire
Copy link
Contributor

Also, even though 12 tests failed, I could see squash and merge cc @0x2b3bfa0

@ilongin ilongin merged commit b111208 into main Sep 14, 2025
62 of 63 checks passed
@ilongin ilongin deleted the ilongin/1338-namespaces-docs branch September 14, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix namespaces docs

3 participants