Remove DATACHAIN_METASTORE_ARG_USERNAME from tests-studio.yml#1203
Merged
Remove DATACHAIN_METASTORE_ARG_USERNAME from tests-studio.yml#1203
DATACHAIN_METASTORE_ARG_USERNAME from tests-studio.yml#1203Conversation
Contributor
Reviewer's GuideThis PR removes a hard-coded DATACHAIN_METASTORE_ARG_USERNAME environment variable from the GitHub Actions tests-studio.yml workflow run command, streamlining the CI configuration by relying on default or external credentials. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Deploying datachain-documentation with
|
| Latest commit: |
8aa14f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://465db56a.datachain-documentation.pages.dev |
| Branch Preview URL: | https://datachain-server-env-test.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
==========================================
+ Coverage 88.70% 88.72% +0.02%
==========================================
Files 152 152
Lines 13577 13577
Branches 1890 1890
==========================================
+ Hits 12043 12046 +3
+ Misses 1090 1088 -2
+ Partials 444 443 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Hey @0x2b3bfa0 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
@ilongin, if you agree, please merge https://github.com/iterative/studio/pull/11846 and then #1203 (this) |
ilongin
approved these changes
Jul 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
CI:
DATACHAIN_METASTORE_ARG_USERNAME=johnfrom thetests-studio.ymljob configuration