Skip to content

Added new reserved char and fixing studio tests #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilongin merged 3 commits into from
Jul 5, 2025
Merged

Added new reserved char and fixing studio tests #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56b0e9a
added new reserved char and fixing studio tests
ilongin Jul 2, 2025
3ead797
Merge branch 'main' into ilongin/11817-change-default-project-namespace
ilongin Jul 4, 2025
acd27c4
fixing running studio tests
ilongin Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests-studio.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:
- name: Run tests
# Generate `.test_durations` file with `pytest --store-durations --durations-path ../.github/.test_durations ...`
run: >
DATACHAIN_METASTORE_ARG_PROJECT=john
DATACHAIN_METASTORE_ARG_USERNAME=john
PYTHONPATH="$(pwd)/..:${PYTHONPATH}"
pytest
--config-file=pyproject.toml -rs
Expand Down
2 changes: 1 addition & 1 deletion src/datachain/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
LISTING_PREFIX = "lst__"

DEFAULT_DATASET_VERSION = "1.0.0"
DATASET_NAME_RESERVED_CHARS = ["."]
DATASET_NAME_RESERVED_CHARS = [".", "@"]
DATASET_NAME_REPLACEMENT_CHAR = "_"


Expand Down
2 changes: 1 addition & 1 deletion src/datachain/namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from datachain.error import InvalidNamespaceNameError

N = TypeVar("N", bound="Namespace")
NAMESPACE_NAME_RESERVED_CHARS = ["."]
NAMESPACE_NAME_RESERVED_CHARS = [".", "@"]
Copy link
Contributor

@shcheklein shcheklein Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to make sure - are those replaced / escaped automatically if username contains them? do we check it when we create the default namespace from the username?

Copy link
Contributor Author

@ilongin ilongin Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are replaced automatically for default namespace and validated when creating random namespace (error is thrown if name contains some of those)



@dataclass(frozen=True)
Expand Down
2 changes: 1 addition & 1 deletion src/datachain/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from datachain.namespace import Namespace

P = TypeVar("P", bound="Project")
PROJECT_NAME_RESERVED_CHARS = ["."]
PROJECT_NAME_RESERVED_CHARS = [".", "@"]


@dataclass(frozen=True)
Expand Down
Loading