-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L4l7 #22
Open
JLeClerc
wants to merge
23
commits into
datacenter:master
Choose a base branch
from
JLeClerc:l4l7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
L4l7 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Joe, Please let us know when you are done and I'll start to review. Thanks, Mike |
…cation.py, update yaml file.
…eholders for virtual device property holders.
…pplication.py, update dynamicallyCreateApplication.yaml and document usage.
Hi Mike, This is all working and tested with dynamicallyCreateApplication.py / dynamicallyCreateApplication.yaml. Could you review it? Thanks, |
…ections of YAML file)
Hi Mike, This is done, could you please review it? Thanks, |
…luster folder parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I don't expect this one to be pulled in right now - this is still a work-in-progress
Instead, could you please review this and let me know what you think? If I am going in the wrong direction, I'd like to know now rather than later.
Thanks,
Joe