change image from owner/user to user/other, issue #308 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NadineBestard
changed the title
|
Thank you for the PR, @NadineBestard Unfortunately, I am unable to view the image. The URL returns a 404 error for me - The page you are trying to reach does not exist, or has been moved. Please use the menus or the search box to find what you are looking for. Do you have another avenue for sharing the image? |
|
I was able to view the image here via GitHub - https://raw.githubusercontent.com/NadineBestard/shell-genomics/0bfc568d746998aef99a48042183353a27669d82/fig/rwx_figure.svg Looks good to me 👍 What do you think, @datacarpentry/shell-genomics-maintainers? |
|
Yep, does not really matter if the original image is not there anymore; as I transformed that image to a svg format, and this is what I used to replace the existing image. |
|
LGTM |
zkamvar
pushed a commit
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not familar with the svg format, so it would be important to check my new image works.
I took it from here:
https://www.booleanworld.com/wp-content/webp-express/webp-images/doc-root/wp-content/uploads/2018/04/classes.png.webp