Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the url to datacarpentry.org, update keywords in config #168

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

bencomp
Copy link
Contributor

@bencomp bencomp commented Jun 15, 2023

This URL is used to generate the JSON-LD metadata, as mentioned in carpentries/sandpaper-docs#137. The editor removed trailing whitespace too.

After merging, the URLs below should point to the proper domain:

<script type="application/ld+json">
    {
  "@context": "https://schema.org",
  "@type": "TrainingMaterial",
  "@id": "https://datacarpentry.github.io/openrefine-socialsci/01-introduction.html",
  "dct:conformsTo": "https://bioschemas.org/profiles/TrainingMaterial/1.0-RELEASE",
  "description": "A Carpentries Lesson teaching foundational data and coding skills to researchers worldwide",
  "keywords": "software, data, lesson, The Carpentries",
  "name": "Introduction",
  "creativeWorkStatus": "active",
  "url": "https://datacarpentry.github.io/openrefine-socialsci/01-introduction.html",
  "identifier": "https://datacarpentry.github.io/openrefine-socialsci/01-introduction.html",
  "dateCreated": "2017-05-25",
  "dateModified": "2023-05-31",
  "datePublished": "2023-06-13"
}
</script>

I will update the keywords too. Other suggestions to improve and enrich the metadata depend on the template and may be tracked in carpentries/sandpaper#481.

This URL is used to generate the JSON-LD metadata.
The editor removed trailing whitespace too.
@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/openrefine-socialsci/compare/md-outputs..md-outputs-PR-168

The following changes were observed in the rendered markdown documents:

 config.yaml | 12 ++++++------
 md5sum.txt  |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-06-15 10:24:42 +0000

github-actions bot pushed a commit that referenced this pull request Jun 15, 2023
@bencomp bencomp marked this pull request as ready for review June 15, 2023 10:22
github-actions bot pushed a commit that referenced this pull request Jun 15, 2023
@bencomp bencomp merged commit 7848817 into datacarpentry:main Jun 15, 2023
github-actions bot pushed a commit that referenced this pull request Jun 15, 2023
Auto-generated via {sandpaper}
Source  : 7848817
Branch  : main
Author  : Ben Companjen <[email protected]>
Time    : 2023-06-15 17:48:02 +0000
Message : Merge pull request #168 from bencomp/config-base-url

Set the url to datacarpentry.org, update keywords in config
github-actions bot pushed a commit that referenced this pull request Jun 15, 2023
Auto-generated via {sandpaper}
Source  : 344ade0
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-06-15 17:49:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 7848817
Branch  : main
Author  : Ben Companjen <[email protected]>
Time    : 2023-06-15 17:48:02 +0000
Message : Merge pull request #168 from bencomp/config-base-url

Set the url to datacarpentry.org, update keywords in config
github-actions bot pushed a commit that referenced this pull request Jun 20, 2023
Auto-generated via {sandpaper}
Source  : 344ade0
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-06-15 17:49:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 7848817
Branch  : main
Author  : Ben Companjen <[email protected]>
Time    : 2023-06-15 17:48:02 +0000
Message : Merge pull request #168 from bencomp/config-base-url

Set the url to datacarpentry.org, update keywords in config
github-actions bot pushed a commit that referenced this pull request Jun 27, 2023
Auto-generated via {sandpaper}
Source  : 344ade0
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-06-15 17:49:44 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 7848817
Branch  : main
Author  : Ben Companjen <[email protected]>
Time    : 2023-06-15 17:48:02 +0000
Message : Merge pull request #168 from bencomp/config-base-url

Set the url to datacarpentry.org, update keywords in config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant