Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug logs to print only the first 96 bytes of the SQL query by default, tunable by debug_truncate_bytes SDK configuration property #859

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Jan 30, 2024

Looking through debug logs might sometimes be challenging due to the amount of information. This PR truncates SQL queries in debug logs by default.

…lt, tunable by `debug_truncate_bytes` SDK configuration property

Looking through debug logs might sometimes be challenging, due to the amount of information in them. This PR truncates SQL queries in debug logs by default.
@nfx nfx requested review from a team and fannijako January 30, 2024 11:31
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (07f03f7) 85.86% compared to head (343a769) 85.75%.

Files Patch % Lines
src/databricks/labs/ucx/runtime.py 15.15% 27 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
- Coverage   85.86%   85.75%   -0.11%     
==========================================
  Files          42       42              
  Lines        5347     5369      +22     
  Branches      969      971       +2     
==========================================
+ Hits         4591     4604      +13     
- Misses        539      547       +8     
- Partials      217      218       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx merged commit ee67586 into main Jan 30, 2024
4 of 7 checks passed
@nfx nfx deleted the chore/query-log-len branch January 30, 2024 11:33
nfx added a commit that referenced this pull request Feb 1, 2024
* Added "what" property for migration to scope down table migrations ([#856](#856)).
* Added job count in the assessment dashboard ([#858](#858)).
* Adopted `installation` package from `databricks-labs-blueprint` ([#860](#860)).
* Debug logs to print only the first 96 bytes of SQL query by default, tunable by `debug_truncate_bytes` SDK configuration property ([#859](#859)).
* Extract command codes and unify the checks for spark_conf, cluster_policy, init_scripts ([#855](#855)).
* Improved installation failure with actionable message ([#840](#840)).
* Improved validating groups membership cli command ([#816](#816)).

Dependency updates:

 * Updated databricks-labs-blueprint requirement from ~=0.1.0 to ~=0.2.4 ([#867](#867)).
@nfx nfx mentioned this pull request Feb 1, 2024
nfx added a commit that referenced this pull request Feb 1, 2024
* Added "what" property for migration to scope down table migrations
([#856](#856)).
* Added job count in the assessment dashboard
([#858](#858)).
* Adopted `installation` package from `databricks-labs-blueprint`
([#860](#860)).
* Debug logs to print only the first 96 bytes of SQL query by default,
tunable by `debug_truncate_bytes` SDK configuration property
([#859](#859)).
* Extract command codes and unify the checks for spark_conf,
cluster_policy, init_scripts
([#855](#855)).
* Improved installation failure with actionable message
([#840](#840)).
* Improved validating groups membership cli command
([#816](#816)).

Dependency updates:

* Updated databricks-labs-blueprint requirement from ~=0.1.0 to ~=0.2.4
([#867](#867)).
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
…tunable by `debug_truncate_bytes` SDK configuration property (#859)

Looking through debug logs might sometimes be challenging due to the
amount of information. This PR truncates SQL queries in debug logs by
default.
dmoore247 pushed a commit that referenced this pull request Mar 23, 2024
* Added "what" property for migration to scope down table migrations
([#856](#856)).
* Added job count in the assessment dashboard
([#858](#858)).
* Adopted `installation` package from `databricks-labs-blueprint`
([#860](#860)).
* Debug logs to print only the first 96 bytes of SQL query by default,
tunable by `debug_truncate_bytes` SDK configuration property
([#859](#859)).
* Extract command codes and unify the checks for spark_conf,
cluster_policy, init_scripts
([#855](#855)).
* Improved installation failure with actionable message
([#840](#840)).
* Improved validating groups membership cli command
([#816](#816)).

Dependency updates:

* Updated databricks-labs-blueprint requirement from ~=0.1.0 to ~=0.2.4
([#867](#867)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant