Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More mypy chores #697

Merged
merged 2 commits into from
Dec 14, 2023
Merged

More mypy chores #697

merged 2 commits into from
Dec 14, 2023

Conversation

nfx
Copy link
Collaborator

@nfx nfx commented Dec 14, 2023

Remaining mypy errors: 131

@nfx
More mypy chores
89f2356 
Remaining `mypy` errors: 131
@nfx nfx requested review from a team and dipankarkush-db December 14, 2023 13:42
@nfx
More mypy chores
edeacf6 
Remaining `mypy` errors: 131
@nfx nfx mentioned this pull request Dec 14, 2023
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (55cf0cb) 79.98% compared to head (edeacf6) 79.77%.

Files Patch % Lines
src/databricks/labs/ucx/assessment/jobs.py 74.19% 13 Missing and 11 partials ⚠️
src/databricks/labs/ucx/assessment/clusters.py 84.93% 4 Missing and 7 partials ⚠️
src/databricks/labs/ucx/workspace_access/groups.py 56.00% 7 Missing and 4 partials ⚠️
src/databricks/labs/ucx/assessment/azure.py 95.37% 0 Missing and 8 partials ⚠️
src/databricks/labs/ucx/account.py 61.53% 3 Missing and 2 partials ⚠️
src/databricks/labs/ucx/hive_metastore/tables.py 66.66% 5 Missing ⚠️
src/databricks/labs/ucx/assessment/init_scripts.py 90.47% 2 Missing and 2 partials ⚠️
src/databricks/labs/ucx/framework/dashboards.py 63.63% 4 Missing ⚠️
src/databricks/labs/ucx/assessment/pipelines.py 92.10% 1 Missing and 2 partials ⚠️
.../databricks/labs/ucx/hive_metastore/hms_lineage.py 85.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   79.98%   79.77%   -0.21%     
==========================================
  Files          38       43       +5     
  Lines        4091     4192     +101     
  Branches      755      764       +9     
==========================================
+ Hits         3272     3344      +72     
- Misses        653      674      +21     
- Partials      166      174       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx merged commit a617047 into main Dec 14, 2023
4 of 6 checks passed
@nfx nfx deleted the chore/mypy2 branch December 14, 2023 13:46
nfx added a commit that referenced this pull request Dec 21, 2023
@nfx
Release v0.7.0
289a4d1 
* Added `databricks labs ucx create-table-mapping` and `databricks labs ucx manual-workspace-info` commands for CLI ([#682](#682)).
* Added `databricks labs ucx installations` command ([#679](#679)).
* Added `databricks labs ucx skip --schema ... --table ...` command to mark table/schema for skipping in the table migration process ([#680](#680)).
* Added `workspace_group_name` and `account_group_name` to `make_ucx_group` fixture ([#664](#664)).
* Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants ([#653](#653)).
* Added cluster override and handle case of write protected DBFS ([#610](#610)).
* Added cluster policy selector in the installer ([#655](#655)).
* Added detailed UCX pre-requisite information to README.md ([#689](#689)).
* Added filters to run only cloud specific task ([#681](#681)).
* Added interactive wizard for `databricks labs uninstall ucx` command ([#657](#657)).
* Added more granular error retry logic ([#704](#704)).
* Added parallel fetching of registered model identifiers to speed-up assessment workflow ([#691](#691)).
* Added retry on workspace listing ([#659](#659)).
* Added support for mapping workspace group to account group by prefix/suffix/regex/external id ([#650](#650)).
* Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as `crawl_tables` was failing when run on non-UC Workspace in No Isolation mode with unable to access the config file ([#661](#661)).
* Changed the fields of the table "Tables" to lower case ([#684](#684)).
* Cleanup README.md ([#695](#695)).
* Cleanup installer framework and speed up test execution ([#711](#711)).
* Decouple group configuration from `install.py` ([#714](#714)).
* Enabled integration tests for `EXTERNAL` table migrations ([#677](#677)).
* Enforced `mypy` validation ([#713](#713)).
* Filtering out inventory database from loading into tables and filtering out the same from grant detail view ([#705](#705)).
* Fixed documentation for `reflect_account_groups_on_workspace` task and updated `CONTRIBUTING.md` guide ([#654](#654)).
* Fixed for secret scope apply task always raises ValueError ([#683](#683)).
* Fixed some flaky integration tests ([#700](#700)).
* More `mypy` chores ([#697](#697)).
* Moved `ExternalLocations` and `Mounts` to `locations` module ([#692](#692)).
* New CLI command for workspace mapping ([#678](#678)).
* No more `mypy` chores after this ([#699](#699)).
* Reduce server load for getting workspace groups and their members ([#666](#666)).
* Some `mypy` chores ([#696](#696)).
* Throwing ManyError on migrate-groups tasks ([#710](#710)).
* Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0 ([#651](#651)).
* Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0 ([#687](#687)).
* Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0 ([#712](#712)).
* Updated installation documentation to use Databricks CLI ([#686](#686)).
nfx added a commit that referenced this pull request Dec 21, 2023
@nfx
Release v0.7.0
3bbc11a 
* Added `databricks labs ucx create-table-mapping` and `databricks labs ucx manual-workspace-info` commands for CLI ([#682](#682)).
* Added `databricks labs ucx installations` command ([#679](#679)).
* Added `databricks labs ucx skip --schema ... --table ...` command to mark table/schema for skipping in the table migration process ([#680](#680)).
* Added `workspace_group_name` and `account_group_name` to `make_ucx_group` fixture ([#664](#664)).
* Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants ([#653](#653)).
* Added cluster override and handle case of write protected DBFS ([#610](#610)).
* Added cluster policy selector in the installer ([#655](#655)).
* Added detailed UCX pre-requisite information to README.md ([#689](#689)).
* Added filters to run only cloud specific task ([#681](#681)).
* Added interactive wizard for `databricks labs uninstall ucx` command ([#657](#657)).
* Added more granular error retry logic ([#704](#704)).
* Added parallel fetching of registered model identifiers to speed-up assessment workflow ([#691](#691)).
* Added retry on workspace listing ([#659](#659)).
* Added support for mapping workspace group to account group by prefix/suffix/regex/external id ([#650](#650)).
* Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as `crawl_tables` was failing when run on non-UC Workspace in No Isolation mode with unable to access the config file ([#661](#661)).
* Changed the fields of the table "Tables" to lower case ([#684](#684)).
* Cleanup README.md ([#695](#695)).
* Cleanup installer framework and speed up test execution ([#711](#711)).
* Decouple group configuration from `install.py` ([#714](#714)).
* Enabled integration tests for `EXTERNAL` table migrations ([#677](#677)).
* Enforced `mypy` validation ([#713](#713)).
* Filtering out inventory database from loading into tables and filtering out the same from grant detail view ([#705](#705)).
* Fixed documentation for `reflect_account_groups_on_workspace` task and updated `CONTRIBUTING.md` guide ([#654](#654)).
* Fixed for secret scope apply task always raises ValueError ([#683](#683)).
* Fixed some flaky integration tests ([#700](#700)).
* More `mypy` chores ([#697](#697)).
* Moved `ExternalLocations` and `Mounts` to `locations` module ([#692](#692)).
* New CLI command for workspace mapping ([#678](#678)).
* No more `mypy` chores after this ([#699](#699)).
* Reduce server load for getting workspace groups and their members ([#666](#666)).
* Some `mypy` chores ([#696](#696)).
* Throwing ManyError on migrate-groups tasks ([#710](#710)).
* Updated installation documentation to use Databricks CLI ([#686](#686)).

Dependency updates:

 * Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0 ([#651](#651)).
 * Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0 ([#687](#687)).
 * Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0 ([#712](#712)).
nfx added a commit that referenced this pull request Dec 21, 2023
@nfx
Release v0.7.0
c241578 
* Added `databricks labs ucx create-table-mapping` and `databricks labs ucx manual-workspace-info` commands for CLI ([#682](#682)).
* Added `databricks labs ucx installations` command ([#679](#679)).
* Added `databricks labs ucx skip --schema ... --table ...` command to mark table/schema for skipping in the table migration process ([#680](#680)).
* Added `workspace_group_name` and `account_group_name` to `make_ucx_group` fixture ([#664](#664)).
* Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants ([#653](#653)).
* Added cluster override and handle case of write protected DBFS ([#610](#610)).
* Added cluster policy selector in the installer ([#655](#655)).
* Added detailed UCX pre-requisite information to README.md ([#689](#689)).
* Added filters to run only cloud specific task ([#681](#681)).
* Added interactive wizard for `databricks labs uninstall ucx` command ([#657](#657)).
* Added more granular error retry logic ([#704](#704)).
* Added parallel fetching of registered model identifiers to speed-up assessment workflow ([#691](#691)).
* Added retry on workspace listing ([#659](#659)).
* Added support for mapping workspace group to account group by prefix/suffix/regex/external id ([#650](#650)).
* Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as `crawl_tables` was failing when run on non-UC Workspace in No Isolation mode with unable to access the config file ([#661](#661)).
* Changed the fields of the table "Tables" to lower case ([#684](#684)).
* Cleanup README.md ([#695](#695)).
* Cleanup installer framework and speed up test execution ([#711](#711)).
* Decouple group configuration from `install.py` ([#714](#714)).
* Enabled integration tests for `EXTERNAL` table migrations ([#677](#677)).
* Enforced `mypy` validation ([#713](#713)).
* Filtering out inventory database from loading into tables and filtering out the same from grant detail view ([#705](#705)).
* Fixed documentation for `reflect_account_groups_on_workspace` task and updated `CONTRIBUTING.md` guide ([#654](#654)).
* Fixed for secret scope apply task always raises ValueError ([#683](#683)).
* Fixed some flaky integration tests ([#700](#700)).
* More `mypy` chores ([#697](#697)).
* Moved `ExternalLocations` and `Mounts` to `locations` module ([#692](#692)).
* New CLI command for workspace mapping ([#678](#678)).
* No more `mypy` chores after this ([#699](#699)).
* Reduce server load for getting workspace groups and their members ([#666](#666)).
* Some `mypy` chores ([#696](#696)).
* Throwing ManyError on migrate-groups tasks ([#710](#710)).
* Updated installation documentation to use Databricks CLI ([#686](#686)).

Dependency updates:

 * Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0 ([#651](#651)).
 * Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0 ([#687](#687)).
 * Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0 ([#712](#712)).
@nfx nfx mentioned this pull request Dec 21, 2023
Closed
nfx added a commit that referenced this pull request Dec 21, 2023
@nfx
Release v0.7.0
ce3af3a 
* Added `databricks labs ucx create-table-mapping` and `databricks labs ucx manual-workspace-info` commands for CLI ([#682](#682)).
* Added `databricks labs ucx installations` command ([#679](#679)).
* Added `databricks labs ucx skip --schema ... --table ...` command to mark table/schema for skipping in the table migration process ([#680](#680)).
* Added `workspace_group_name` and `account_group_name` to `make_ucx_group` fixture ([#664](#664)).
* Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants ([#653](#653)).
* Added cluster override and handle case of write protected DBFS ([#610](#610)).
* Added cluster policy selector in the installer ([#655](#655)).
* Added detailed UCX pre-requisite information to README.md ([#689](#689)).
* Added filters to run only cloud specific task ([#681](#681)).
* Added interactive wizard for `databricks labs uninstall ucx` command ([#657](#657)).
* Added more granular error retry logic ([#704](#704)).
* Added parallel fetching of registered model identifiers to speed-up assessment workflow ([#691](#691)).
* Added retry on workspace listing ([#659](#659)).
* Added support for mapping workspace group to account group by prefix/suffix/regex/external id ([#650](#650)).
* Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as `crawl_tables` was failing when run on non-UC Workspace in No Isolation mode with unable to access the config file ([#661](#661)).
* Changed the fields of the table "Tables" to lower case ([#684](#684)).
* Cleanup README.md ([#695](#695)).
* Cleanup installer framework and speed up test execution ([#711](#711)).
* Decouple group configuration from `install.py` ([#714](#714)).
* Enabled integration tests for `EXTERNAL` table migrations ([#677](#677)).
* Enforced `mypy` validation ([#713](#713)).
* Filtering out inventory database from loading into tables and filtering out the same from grant detail view ([#705](#705)).
* Fixed documentation for `reflect_account_groups_on_workspace` task and updated `CONTRIBUTING.md` guide ([#654](#654)).
* Fixed for secret scope apply task always raises ValueError ([#683](#683)).
* Fixed some flaky integration tests ([#700](#700)).
* More `mypy` chores ([#697](#697)).
* Moved `ExternalLocations` and `Mounts` to `locations` module ([#692](#692)).
* New CLI command for workspace mapping ([#678](#678)).
* No more `mypy` chores after this ([#699](#699)).
* Reduce server load for getting workspace groups and their members ([#666](#666)).
* Some `mypy` chores ([#696](#696)).
* Throwing ManyError on migrate-groups tasks ([#710](#710)).
* Updated installation documentation to use Databricks CLI ([#686](#686)).

Dependency updates:

 * Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0 ([#651](#651)).
 * Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0 ([#687](#687)).
 * Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0 ([#712](#712)).
@nfx nfx mentioned this pull request Dec 21, 2023
Closed
nfx added a commit that referenced this pull request Dec 21, 2023
@nfx
Release v0.7.0
29a6410 
* Added `databricks labs ucx create-table-mapping` and `databricks labs ucx manual-workspace-info` commands for CLI ([#682](#682)).
* Added `databricks labs ucx installations` command ([#679](#679)).
* Added `databricks labs ucx skip --schema ... --table ...` command to mark table/schema for skipping in the table migration process ([#680](#680)).
* Added `databricks labs ucx validate-external-locations` command for cli ([#715](#715)).
* Added `workspace_group_name` and `account_group_name` to `make_ucx_group` fixture ([#664](#664)).
* Added capturing `ANY FILE` and `ANONYMOUS FUNCTION` grants ([#653](#653)).
* Added cluster override and handle case of write protected DBFS ([#610](#610)).
* Added cluster policy selector in the installer ([#655](#655)).
* Added detailed UCX pre-requisite information to README.md ([#689](#689)).
* Added filters to run only cloud specific task ([#681](#681)).
* Added interactive wizard for `databricks labs uninstall ucx` command ([#657](#657)).
* Added more granular error retry logic ([#704](#704)).
* Added parallel fetching of registered model identifiers to speed-up assessment workflow ([#691](#691)).
* Added retry on workspace listing ([#659](#659)).
* Added support for mapping workspace group to account group by prefix/suffix/regex/external id ([#650](#650)).
* Changed cluster security mode from NONE to LEGACY_SINGLE_USER, as `crawl_tables` was failing when run on non-UC Workspace in No Isolation mode with unable to access the config file ([#661](#661)).
* Changed the fields of the table "Tables" to lower case ([#684](#684)).
* Cleanup README.md ([#695](#695)).
* Cleanup installer framework and speed up test execution ([#711](#711)).
* Decouple group configuration from `install.py` ([#714](#714)).
* Enabled integration tests for `EXTERNAL` table migrations ([#677](#677)).
* Enforced `mypy` validation ([#713](#713)).
* Filtering out inventory database from loading into tables and filtering out the same from grant detail view ([#705](#705)).
* Fixed documentation for `reflect_account_groups_on_workspace` task and updated `CONTRIBUTING.md` guide ([#654](#654)).
* Fixed for secret scope apply task always raises ValueError ([#683](#683)).
* Fixed some flaky integration tests ([#700](#700)).
* More `mypy` chores ([#697](#697)).
* Moved `ExternalLocations` and `Mounts` to `locations` module ([#692](#692)).
* New CLI command for workspace mapping ([#678](#678)).
* No more `mypy` chores after this ([#699](#699)).
* Reduce server load for getting workspace groups and their members ([#666](#666)).
* Some `mypy` chores ([#696](#696)).
* Throwing ManyError on migrate-groups tasks ([#710](#710)).
* Updated installation documentation to use Databricks CLI ([#686](#686)).

Dependency updates:

 * Updated databricks-sdk requirement from ~=0.13.0 to ~=0.14.0 ([#651](#651)).
 * Updated databricks-sdk requirement from ~=0.14.0 to ~=0.15.0 ([#687](#687)).
 * Updated databricks-sdk requirement from ~=0.15.0 to ~=0.16.0 ([#712](#712)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipankarkush-db dipankarkush-db Awaiting requested review from dipankarkush-db

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nfx