Table migration mapping #525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FastLee
had a problem deploying
to
account-admin
GitHub Actions
Failure
FastLee
had a problem deploying
to
account-admin
GitHub Actions
Failure
william-conti
suggested changes
Nov 24, 2023
| if re.match(r"^\w+$", default_catalog): | ||
| break | ||
| else: | ||
| print(f"{default_catalog} is not a valid catalog name") |
There was a problem hiding this comment.
Make a logger.warn instead and provide a hint for what's a "valid catalog name"
| mapping = "element,target,notes\n" | ||
| mapping += f"<root>,{default_catalog},Default Mapping created by UCX Install\n" | ||
| path = f"{self._install_folder}/table_upgrade_map.csv" | ||
| self._ws.workspace.upload(path, mapping.encode("utf8"), format=ImportFormat.AUTO, overwrite=True) |
There was a problem hiding this comment.
Add some test to validate that we've indeed saved the catalog name
| @@ -778,6 +799,11 @@ def _get_ext_hms_conf_from_policy(cluster_policy): | |||
| spark_conf_dict[key[11:]] = cluster_policy[key]["value"] | |||
| return instance_profile, spark_conf_dict | |||
|
|
|||
| def _write_mapping_conf_file(self, default_catalog: str): | |||
| mapping = "element,target,notes\n" | |||
| mapping += f"<root>,{default_catalog},Default Mapping created by UCX Install\n" | |||
There was a problem hiding this comment.
I don't really understand the scope of this PR, why would we write a mapping file when the user can only enter the default catalog name ?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #304