Implement disposition field in SQL backend #3477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
had a problem deploying
to
account-admin
GitHub Actions
Failure
JCZuurmond
changed the title
|
✅ 24/24 passed, 1 flaky, 32m21s total Flaky tests:
Running from acceptance #7919 |
Having this feature will allow the execution of queries with not negligible dimension results. Using this field during the configuration, will allow to export assessment results for larger workspaces.
JCZuurmond
force-pushed
the
sql-statement-disposition-feature
branch
from
9a7c8d1 to
780a3c6
Compare
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
2 tasks
FastLee
requested changes
Jan 8, 2025
| @@ -92,6 +93,9 @@ class WorkspaceConfig: # pylint: disable=too-many-instance-attributes | |||
| # Skip TACL migration during table migration | |||
| skip_tacl_migration: bool = False | |||
|
|
|||
| # Select SQL query statement disposition, default to INLINE | |||
| query_statement_disposition: Disposition | None = None | |||
There was a problem hiding this comment.
Suggested change
| query_statement_disposition: Disposition | None = None | |
| query_statement_disposition: Disposition = Disposition.INLINE |
| @@ -259,6 +260,12 @@ def _prompt_for_new_installation(self) -> WorkspaceConfig: | |||
| recon_tolerance_percent = int( | |||
| self.prompts.question("Reconciliation threshold, in percentage", default="5", valid_number=True) | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
I would reconsider. This may be confusing to the users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature aims to the chance of running SQL statement for assessment results export in case of large workspaces with a large amount of findings.
Introducing the
query_statement_dispositionvalue during the UCX installation can allow users to select the proper disposition method to use when running large queries. This parameter is added in theconfig.ymlfile and used for the SqlBackend definition. Using this approach, large queries will not fail.Changes
Added SQL query statement disposition choice during the UCX installation
Added
query_statement_dispositionvalue in the config fileLinked issues
Resolves #3447
From other PR #3455
Functionality
databricks labs install ucx,databricks labs ucx export-assessmentTests