-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse code between runtime_ctx
, installation_ctx
and other integration testing contexts
#3085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation testing contexts
❌ 125/129 passed, 4 failed, 26 skipped, 4h5m10s total ❌ test_migration_job_ext_hms[regular]: databricks.sdk.errors.platform.NotFound: [SCHEMA_NOT_FOUND] The schema `dummy_stt8k` cannot be found. Verify the spelling and correctness of the schema and catalog. (6m39.507s)
❌ test_create_catalog_schema_with_principal_acl_CLOUD_ENV: AssertionError: assert PrivilegeAssignment(principal='[email protected]', privileges=[]) in [] (2m34.123s)
❌ test_migrate_external_tables_with_spn_CLOUD_ENV: assert False (1m52.482s)
❌ test_migrate_external_tables_with_principal_acl_CLOUD_ENV: assert False (2m39.899s)
Running from acceptance #7088 |
asnare
reviewed
Nov 5, 2024
def __init__( | ||
self, | ||
ws: WorkspaceClient, | ||
sql_backend: SqlBackend, | ||
schema: str, | ||
tables_crawler: TablesCrawler, | ||
mounts_crawler: 'MountsCrawler', | ||
mounts_crawler: CrawlerBase['Mount'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
mounts_crawler: CrawlerBase['Mount'], | |
mounts_crawler: CrawlerBase[Mount], |
1 task
Created issue to pick in planning, closing this PR for now to clean up, can reopen later: See #3085 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug/test-infra
issues related to testing infrastructure
internal
this pull request won't appear in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.