Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DuckdbDB lint message from known.json #2170

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

JCZuurmond
Copy link
Member

Remove the lint message for DuckDB from knownd.json as it does not use Spark, nor does it change behavior based on the Databricks runtime. See this comment for more context

DuckDB does not use Spark, nor does it change behavior based on the Databricks runtime
@JCZuurmond JCZuurmond requested review from nfx, ericvergnaud and a team July 15, 2024 10:16
Copy link

✅ 26/26 passed, 1 skipped, 12m56s total

Running from acceptance #4664

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit c3167b1 into main Jul 15, 2024
4 checks passed
@nfx nfx deleted the fix/remove-false-postive-duckdb-lint-message-in-known branch July 15, 2024 10:54
@nfx nfx added the internal this pull request won't appear in release notes label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal this pull request won't appear in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants