Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelist toolz #2146

Merged
merged 3 commits into from
Jul 11, 2024
Merged

whitelist toolz #2146

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71a3325
whitelist toolz
ericvergnaud Jul 10, 2024
cce24d1
Merge branch 'main' into whitelist-toolz
ericvergnaud Jul 11, 2024
c1a661e
Merge branch 'main' into whitelist-toolz
ericvergnaud Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/databricks/labs/ucx/source_code/known.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26274,6 +26274,25 @@
"tomlkit": {
"tomlkit": []
},
"toolz": {
"tlz": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question about the tlz not matching toolz as in other Pr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't control this. The pypi package is toolz, it contains a tlz module, see https://github.com/pytoolz/toolz/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I understand that, but want to confirm that our logic will still work when this is the case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was tested by running make solacc so I confirm

"tlz._build_tlz": [],
"toolz": [],
"toolz._signatures": [],
"toolz._version": [],
"toolz.compatibility": [],
"toolz.curried": [],
"toolz.curried.exceptions": [],
"toolz.curried.operator": [],
"toolz.dicttoolz": [],
"toolz.functoolz": [],
"toolz.itertoolz": [],
"toolz.recipes": [],
"toolz.sandbox": [],
"toolz.sandbox.core": [],
"toolz.sandbox.parallel": [],
"toolz.utils": []
},
"torch": {
"functorch": [],
"torch": []
Expand Down