Tidy up whitespace #1923
Merged
Tidy up whitespace #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
=======================================
Coverage 89.59% 89.59%
=======================================
Files 95 95
Lines 12347 12347
Branches 2166 2166
=======================================
Hits 11062 11062
Misses 864 864
Partials 421 421 ☔ View full report in Codecov by Sentry. |
|
❌ 197/198 passed, 2 flaky, 1 failed, 23 skipped, 4h34m38s total ❌ test_running_real_validate_groups_permissions_job: TimeoutError: Timed out after 0:05:00 (6m48.022s)Flaky tests:
Running from acceptance #4045 |
JCZuurmond
requested changes
Jun 24, 2024
It's a side-effect of the editor settings in #1778. Historically we have quite a few files with trailing whitespace and missing the EOL at EOF. These aren't enforced by linting (which only covers python code), but with the new editor settings in place any time you modify a file trailing whitespace elsewhere in the file will be stripped. This was intended as a fix-them-all-for-now PR to avoid spurious updates on other PRs, particularly in Markdown.
Agreed; I'm happy to drop those given that the file is generated. |
This is a generated file.
JCZuurmond
approved these changes
Jun 27, 2024
nfx
requested changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR follows on from #1778 by cleaning up files that use tabs, have trailing whitespace, or are missing EOL at the end of files. By fixing these in one go other PRs become less noisy. (Sample files used in tests have been left alone and are not affected by this PR.)