Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more inference tests #1908

Merged
merged 1 commit into from
Jun 14, 2024
Merged

more inference tests #1908

merged 1 commit into from
Jun 14, 2024

Conversation

ericvergnaud
Copy link
Contributor

Changes

more tests

Linked issues

Progresses #1901

Functionality

None

Tests

  • added unit tests

@ericvergnaud ericvergnaud requested review from a team and aminmovahed-db June 14, 2024 10:37
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (4414463) to head (dea0736).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1908   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files          95       95           
  Lines       12329    12329           
  Branches     2164     2164           
=======================================
  Hits        11044    11044           
  Misses        864      864           
  Partials      421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✅ 194/194 passed, 24 skipped, 3h19m7s total

Running from acceptance #3944

Copy link
Member

@JCZuurmond JCZuurmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit deae2df Jun 14, 2024
8 checks passed
@nfx nfx deleted the infer-values-from-string-format branch June 14, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants