-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues when running solacc #1902
Conversation
…' of github.com:databrickslabs/ucx into infer-linted-values-that-resolve-to-dbutils.widgets.get
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1902 +/- ##
=======================================
Coverage 89.57% 89.58%
=======================================
Files 95 95
Lines 12329 12333 +4
Branches 2164 2166 +2
=======================================
+ Hits 11044 11048 +4
Misses 864 864
Partials 421 421 ☔ View full report in Codecov by Sentry. |
@ericvergnaud #1891 is orthogonal to to reducing noise |
# Conflicts: # tests/integration/source_code/test_jobs.py
some noise comes from failing to infer values |
❌ 193/194 passed, 1 failed, 24 skipped, 2h44m31s total ❌ test_running_real_validate_groups_permissions_job_fails: databricks.labs.blueprint.parallel.ManyError: Detected 1 failures: ResourceDoesNotExist: Scope sdk-wvlo does not exist! (3m5.714s)
Running from acceptance #3939 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@nfx this PR relies on #1891
Changes
Linked issues
Progresses #1901
Functionality
databricks labs ucx ...
...
...
Tests