Support inferred values when linting sys path - saved #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
requested changes
Jun 7, 2024
| elif isinstance(base_node, ImportSource): | ||
| yield from self._register_import(base_node) | ||
| else: | ||
| logger.error(f"Can't process {NodeBase.__name__} of type {type(base_node).__name__}") |
There was a problem hiding this comment.
Suggested change
| logger.error(f"Can't process {NodeBase.__name__} of type {type(base_node).__name__}") | |
| logger.warning(f"Can't process {NodeBase.__name__} of type {type(base_node).__name__}") |
Error logs fail the workflow
|
|
||
| def _visit_inferred(self, changed: NodeNG, inferred: NodeNG, is_relative: bool, is_append: bool): | ||
| if inferred is Uninferable or not isinstance(inferred, Const): | ||
| self.sys_path_changes.append(UnresolvedPath(changed, changed.as_string(), is_append)) |
There was a problem hiding this comment.
Suggested change
| self.sys_path_changes.append(UnresolvedPath(changed, changed.as_string(), is_append)) | |
| self.sys_path_changes.append(UnresolvedPath(changed, changed.as_string(), is_append)) | |
| return |
Can we explicitly return, so that branches won't fall through accidentally?
ericvergnaud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Infer value of sys.path.xxx() calls and raise advice if unresolved
Linked issues
Progresses #1205
Functionality
databricks labs ucx .........Tests