[WIP] add command for migrating views #1232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qziyuan
requested changes
Apr 4, 2024
There was a problem hiding this comment.
Hi @ericvergnaud could you take a look at and double check this issue #1273? I think the old _migrate_view_table function is creating UC view with old HMS dependencies.
JCZuurmond
requested changes
Apr 5, 2024
| cluster_locations = {} | ||
| if ws.config.is_azure: | ||
| locations = ExternalLocations(ws, sql_backend, cfg.inventory_database) | ||
| azure_client = AzureAPIClient( |
There was a problem hiding this comment.
See message in Slack from @nfx about these calls only existing from the cli not within a job
nfx
added
pr/do-not-merge
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
+ Coverage 90.02% 90.19% +0.16%
==========================================
Files 62 62
Lines 7430 7709 +279
Branches 1335 1387 +52
==========================================
+ Hits 6689 6953 +264
- Misses 470 483 +13
- Partials 271 273 +2 ☔ View full report in Codecov by Sentry. |
|
closing in favor of #1325 |
ericvergnaud
had a problem deploying
to
account-admin
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
add a command for migrating views
factorize code
Linked issues
Resolves #1172
Functionality
databricks labs ucx .........Tests
Missing integration tests
Depends on #1177