DBR 16 and later support #3481
Open
DBR 16 and later support #3481
+9
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the run/wait pattern in the rest of our tests so that we can set a breakpoint on the wait and watch the workflow run.
JCZuurmond
approved these changes
Jan 6, 2025
|
❌ 50/56 passed, 2 flaky, 6 failed, 4 skipped, 4h30m48s total ❌ test_table_migration_job_refreshes_migration_status[hiveserde-migrate-external-tables-ctas]: AssertionError: Workflow failed: assessment (21m27.286s)❌ test_table_migration_job_refreshes_migration_status[regular-migrate-tables]: AssertionError: Workflow failed: assessment (21m33.62s)❌ test_hiveserde_table_in_place_migration_job[migrate-external-tables-ctas]: AssertionError: Workflow failed: assessment (21m34.186s)❌ test_table_migration_job_publishes_remaining_tables: AssertionError: Workflow failed: assessment (23m35.99s)❌ test_hiveserde_table_in_place_migration_job[migrate-external-hiveserde-tables-in-place-experimental]: AssertionError: Workflow failed: migrate-external-hiveserde-tables-in-place-experimental (24m36.528s)❌ test_table_migration_convert_manged_to_external: AssertionError: assert False (24m40.489s)Flaky tests:
Running from acceptance #7887 |
asnare
commented
Jan 7, 2025
| @@ -327,6 +323,8 @@ def _convert_hms_table_to_external(self, src_table: Table) -> bool: | |||
| old_table.schemaPreservesCase(), | |||
| old_table.ignoredProperties(), | |||
| old_table.viewOriginalText(), | |||
| # From DBR 16, there's a new table property: entityStorageLocations (Seq[EntityStorageLocation]) | |||
| *([old_table.entityStorageLocations()] if hasattr(old_table, 'entityStorageLocations') else []), | |||
There was a problem hiding this comment.
@FastLee: I assume that this (new) property should be copied from the old table when doing this migration?
asnare
requested a deployment
to
account-admin
GitHub Actions
In progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds DBR16 compatibility for the code that (optionally) converts HMS tables to external tables within the
migrate-tablesworkflow.Linked issues
Follows #3459
Resolves #3460
Functionality
migrate-tablesTests