Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: CONVERT_TO_EXTERNAL table migration strategy does not work for Databricks runtime 16.0 #3460

Closed
1 task done
JCZuurmond opened this issue Dec 20, 2024 · 0 comments · Fixed by #3481
Closed
1 task done

[BUG]: CONVERT_TO_EXTERNAL table migration strategy does not work for Databricks runtime 16.0 #3460

JCZuurmond opened this issue Dec 20, 2024 · 0 comments · Fixed by #3481
Assignees
@asnare
Labels
needs-triage

Comments

@JCZuurmond
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

CONVERT_TO_EXTERNAL table migration strategy does not work for Databricks runtime 16.0.

More specifically, the logic in

ucx/src/databricks/labs/ucx/hive_metastore/table_migrate.py

Line 296 in 938e4c5

def _convert_hms_table_to_external(self, src_table: Table):

Expected Behavior

CONVERT_TO_EXTERNAL table migration strategy should work for Databricks runtime 16.0

Steps To Reproduce

Revert PR #3459

Cloud

Azure

Operating System

macOS

Version

latest via Databricks CLI

Relevant log output

No response
@JCZuurmond JCZuurmond added this to UCX Dec 20, 2024
@github-project-automation github-project-automation bot moved this to Todo in UCX Dec 20, 2024
@JCZuurmond JCZuurmond mentioned this issue Jan 6, 2025
Merged
@JCZuurmond JCZuurmond moved this from Todo to In Progress in UCX Jan 6, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2025
@asnare
DBR 16 and later support (#3481)
368b3a5 
## Changes

This PR adds DBR16 compatibility for the code that (optionally) converts
HMS tables to external tables within the `migrate-tables` workflow.

### Linked issues

Follows #3459
Resolves #3460

### Functionality

- modified existing workflow: `migrate-tables`

### Tests

- manually tested (for DBR16)
- existing integration tests (for DBR15)
- verified on staging environment (with DBR16, see screenshot below)


![image](https://github.com/user-attachments/assets/ae75c4fb-2d6e-4bad-907c-2f9b8b3abff0)
@github-project-automation github-project-automation bot moved this from In Progress to Done in UCX Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asnare asnare

Labels
needs-triage
Projects
UCX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DBR 16 and later support databrickslabs/ucx
2 participants
@asnare @JCZuurmond