Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH DEBT]: Exclude the UCX dashboards from the LakeviewDashboardCrawler #3441

Closed
1 task done
JCZuurmond opened this issue Dec 12, 2024 · 0 comments · Fixed by #3450
Closed
1 task done

[TECH DEBT]: Exclude the UCX dashboards from the LakeviewDashboardCrawler #3441

JCZuurmond opened this issue Dec 12, 2024 · 0 comments · Fixed by #3450
Assignees
@JCZuurmond
Labels
enhancement New feature or request needs-triage

Comments

@JCZuurmond
Copy link
Member

JCZuurmond commented Dec 12, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

The LakeviewDashboardCrawler introduced in #3397 includes the UCX dashboards

Proposed Solution

Exclude the UCX dashboards:

  1. Add a exclude_dashboard_ids to the class
  2. Pass the ids from the UCX state to the class

Additional Context

No response
@JCZuurmond JCZuurmond added enhancement New feature or request needs-triage labels Dec 12, 2024
@JCZuurmond JCZuurmond added this to UCX Dec 12, 2024
@github-project-automation github-project-automation bot moved this to Todo in UCX Dec 12, 2024
@JCZuurmond JCZuurmond mentioned this issue Dec 16, 2024
Merged
4 tasks
@JCZuurmond JCZuurmond moved this from Todo to Ready for Review in UCX Dec 16, 2024
@JCZuurmond JCZuurmond self-assigned this Dec 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 7, 2025
@JCZuurmond
Exclude ucx dashboards from Lakeview dashboard crawler (#3450)
505a062 
## Changes
Exclude ucx dashboards from Lakeview dashboard crawler as this would be
a false positive dashboard

### Linked issues
Resolves #3441

### Functionality

- [x] modified existing workflow: `assessment`

### Tests

- [x] manually tested
- [x] added unit tests
- [x] verified on staging environment (screenshot attached)
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in UCX Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JCZuurmond JCZuurmond

Labels
enhancement New feature or request needs-triage
Projects
UCX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude ucx dashboards from Lakeview dashboard crawler databrickslabs/ucx
1 participant
@JCZuurmond