Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Mark notebooks as migrated #1327

Closed
1 task done
Tracked by #1204
ericvergnaud opened this issue Apr 8, 2024 · 3 comments
Closed
1 task done
Tracked by #1204

[FEATURE]: Mark notebooks as migrated #1327

ericvergnaud opened this issue Apr 8, 2024 · 3 comments
Labels
migrate/code Abstract Syntax Trees and other dark magic

Comments

@ericvergnaud
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Problem statement

There is currently no way to mark notebooks as migrated. This is suboptimal because when migrating notebook dependencies, we may end up migrating the same notebook more than once

Proposed Solution

Register migrated notebooks

Additional Context

No response
@ericvergnaud ericvergnaud added enhancement New feature or request needs-triage labels Apr 8, 2024
@github-project-automation github-project-automation bot moved this to Triage in UCX Apr 8, 2024
@nfx nfx added migrate/code Abstract Syntax Trees and other dark magic and removed needs-triage enhancement New feature or request labels Apr 10, 2024
@ericvergnaud ericvergnaud mentioned this issue Apr 16, 2024
Merged
11 tasks
nfx pushed a commit that referenced this issue Apr 16, 2024
@ericvergnaud
comment decision (#1416)
ad319fe 
## Changes
Add comment

### Linked issues
#1327

### Functionality 

- [ ] added relevant user documentation
- [ ] added new CLI command
- [ ] modified existing command: `databricks labs ucx ...`
- [ ] added a new workflow
- [ ] modified existing workflow: `...`
- [ ] added a new table
- [ ] modified existing table: `...`

### Tests

- [ ] manually tested
- [ ] added unit tests
- [ ] added integration tests
- [ ] verified on staging environment (screenshot attached)
@nfx nfx mentioned this issue Apr 24, 2024
Open
14 tasks
@nfx nfx moved this from Triage to Quarter Backlog in UCX May 2, 2024
@nfx
Copy link
Collaborator

nfx commented Jul 3, 2024

Technically, we can have an ignore list in teh .ucx folder, which will be human-editable and we can skip certain notebooks

@nfx nfx moved this from Quarter Backlog to Active Backlog in UCX Jul 4, 2024
@JCZuurmond
Copy link
Member

Rerunning code migration on an already migrated code should result the same code, otherwise that is a bug. So this is a performance improvement

@nfx
Copy link
Collaborator

nfx commented Jul 17, 2024

Closing in favor of #2073

@nfx nfx closed this as completed Jul 17, 2024
@github-project-automation github-project-automation bot moved this from Active Backlog to Archive in UCX Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
migrate/code Abstract Syntax Trees and other dark magic
Projects
UCX
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nfx @ericvergnaud @JCZuurmond